On Mon, Apr 18, 2022 at 12:43:56PM -0400, Tom Rix wrote: > Smatch reports this issue > vchiq_arm.c:466:5: warning: symbol 'vchiq_platform_init' > was not declared. Should it be static? This is a Sparse warning, not Smatch. Use this command for Smatch ~/smatch/smatch_scripts/kchecker drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c And this command for Sparse ~/smatch/smatch_scripts/kchecker --sparse drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c regards, dan carpenter