On Mon, Mar 28, 2022 at 01:39:40PM +0200, Michael Straube wrote: > The HW_VAR_BCN_VALID case in SetHwReg8188EU() just calls rtw_write8(). > Remove HW_VAR_BCN_VALID from SetHwReg8188EU() and call rtw_write8() > directly. This is part of the ongoing effort to getrid of the unwanted > hal layer. > > Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx> > --- > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 5 ++++- > drivers/staging/r8188eu/hal/rtl8188e_cmd.c | 12 ++++++++---- > drivers/staging/r8188eu/hal/usb_halinit.c | 4 ---- > 3 files changed, 12 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme_ext.c b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > index b5c2e7d4cb48..313e1a3beecb 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme_ext.c > @@ -5765,7 +5765,10 @@ unsigned int send_beacon(struct adapter *padapter) > > u32 start = jiffies; > > - SetHwReg8188EU(padapter, HW_VAR_BCN_VALID, NULL); > + /* Clear beacon valid check bit. */ > + /* BIT(16) of REG_TDECTRL = BIT(0) of REG_TDECTRL+2, write 1 to clear, Clear by sw */ > + rtw_write8(padapter, REG_TDECTRL + 2, rtw_read8(padapter, REG_TDECTRL + 2) | BIT(0)); You commented this twice, it should be a single function :) thanks, greg k-h
