On Mon, Mar 28, 2022 at 01:39:39PM +0200, Michael Straube wrote: > The HW_VAR_TX_RPT_MAX_MACID case in SetHwReg8188EU() just calls > rtw_write8(). Remove HW_VAR_TX_RPT_MAX_MACID from SetHwReg8188EU() and > call rtw_write8() directly. This is part of the ongoing effort to get > rid of the unwanted hal layer. > > Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx> > --- > drivers/staging/r8188eu/core/rtw_mlme.c | 3 ++- > drivers/staging/r8188eu/core/rtw_mlme_ext.c | 3 ++- > drivers/staging/r8188eu/hal/usb_halinit.c | 6 ------ > drivers/staging/r8188eu/include/hal_intf.h | 1 - > 4 files changed, 4 insertions(+), 9 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_mlme.c b/drivers/staging/r8188eu/core/rtw_mlme.c > index 1569f719af1b..06c17a16dab9 100644 > --- a/drivers/staging/r8188eu/core/rtw_mlme.c > +++ b/drivers/staging/r8188eu/core/rtw_mlme.c > @@ -1141,7 +1141,8 @@ void rtw_sta_media_status_rpt(struct adapter *adapter, struct sta_info *psta, > return; > > macid = search_max_mac_id(adapter); > - SetHwReg8188EU(adapter, HW_VAR_TX_RPT_MAX_MACID, (u8 *)&macid); > + rtw_write8(adapter, REG_TX_RPT_CTRL + 1, macid + 1); This too should be a function to help explain what you are doing. thanks, greg k-h
