Greetings Greg, >On Wed, Mar 16, 2022 at 06:13:04PM +0000, Czerwacki, Eial wrote: >> Introducing the vSMP guest driver which allows interaction with the vSMP control device when >> running a Linux OS atop of the vSMP hypervisor. >> vSMP is a resource aggregation hypervisor from SAP. >> >> the driver comprises of 3 modules, vsmp which includes all the api needed to interact with the >> control driver, vsmp_logs which allows reading logs from the hypervisor and vsmp_common_info which >> allows reading generic information the hypervisor exposes, currently only the version is exposed. > >Please wrap changelog text at 72 columns, like git asks you to. git didn't asked me to do so, I'll fix it in the next iteration. > >Also, why did you not cc: the staging maintainer? :( I've probably missed that when I was going over the docs, my bad. > >> Signed-off-by: Eial Czerwacki <eial.czerwacki@xxxxxxx> >> --- >> MAINTAINERS | 6 + >> drivers/staging/Kconfig | 2 + >> drivers/staging/Makefile | 1 + >> drivers/staging/vsmp/Kconfig | 14 + >> drivers/staging/vsmp/Makefile | 7 + >> drivers/staging/vsmp/api.c | 402 ++++++++++++++++++++++++ >> drivers/staging/vsmp/api.h | 61 ++++ >> drivers/staging/vsmp/common/Kconfig | 11 + >> drivers/staging/vsmp/common/Makefile | 7 + >> drivers/staging/vsmp/common/common.c | 64 ++++ >> drivers/staging/vsmp/common/common.h | 27 ++ >> drivers/staging/vsmp/common/version.c | 85 +++++ >> drivers/staging/vsmp/logs/Kconfig | 10 + >> drivers/staging/vsmp/logs/Makefile | 7 + >> drivers/staging/vsmp/logs/active_logs.c | 112 +++++++ >> drivers/staging/vsmp/registers.h | 16 + > >Without looking at the code, I do not see a TODO file here that lists >the tasks that need to be completed to get this out of the >drivers/staging/ directory. This is a requirement. there are tasks to complete it however I'm not sure they are blockers. > >Also, why is this submitted for drivers/staging/ ? What prevents it >from being merged to the "correct" place in the kernel tree today? afaiu, the correct order for new drivers is staging => mainline. in addition, from past experience with the main kernel mailing list, I thought the driver will get more traction here than in the main kernel mailing list. unless there is a specific mailing list for drivers beside the staging tree one Thank, Eial
