On Wed, Mar 16, 2022 at 06:13:04PM +0000, Czerwacki, Eial wrote: > Introducing the vSMP guest driver which allows interaction with the vSMP control device when > running a Linux OS atop of the vSMP hypervisor. > vSMP is a resource aggregation hypervisor from SAP. > > the driver comprises of 3 modules, vsmp which includes all the api needed to interact with the > control driver, vsmp_logs which allows reading logs from the hypervisor and vsmp_common_info which > allows reading generic information the hypervisor exposes, currently only the version is exposed. > > Signed-off-by: Eial Czerwacki <eial.czerwacki@xxxxxxx> > --- > MAINTAINERS | 6 + > drivers/staging/Kconfig | 2 + > drivers/staging/Makefile | 1 + > drivers/staging/vsmp/Kconfig | 14 + > drivers/staging/vsmp/Makefile | 7 + > drivers/staging/vsmp/api.c | 402 ++++++++++++++++++++++++ > drivers/staging/vsmp/api.h | 61 ++++ > drivers/staging/vsmp/common/Kconfig | 11 + > drivers/staging/vsmp/common/Makefile | 7 + > drivers/staging/vsmp/common/common.c | 64 ++++ > drivers/staging/vsmp/common/common.h | 27 ++ > drivers/staging/vsmp/common/version.c | 85 +++++ > drivers/staging/vsmp/logs/Kconfig | 10 + > drivers/staging/vsmp/logs/Makefile | 7 + > drivers/staging/vsmp/logs/active_logs.c | 112 +++++++ > drivers/staging/vsmp/registers.h | 16 + > 16 files changed, 832 insertions(+) 800 lines of code turn into 3 modules? Why isn't this just one module? Why split them at all? thanks, greg k-h