On Fri, Jan 07, 2022 at 04:05:40PM +0530, Abdun Nihaal wrote: > Remove unneeded return variables in ioctl_linux.c that are initialized > to 0 and are not assigned after. Instead, return 0 directly. Many, if not most, of these functions should either be having their return value checked, or be void functions as no one checks their return value and they can not fail. Please split this up and look at each function to determine which is is and how to fix it up properly. Just returning 0 all the time is not the correct thing to do all the time. One example would be rtw_p2p_get_status() It can not fail, so why does it return anything? thanks, greg k-h