Re: [PATCH 4/4] staging: mt7621-dts: fix pinctrl properties for ethernet

[Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>]

On Mon, Jan 24, 2022 at 1:45 PM Arınç ÜNAL <arinc.unal@xxxxxxxxxx> wrote:
>
> Add pinctrl properties with rgmii1 & mdio pins under ethernet node which
> was wrongfully put under an external phy node.
> GMAC1 will start working with this fix.
>
> Link: https://lore.kernel.org/netdev/02ecce91-7aad-4392-c9d7-f45ca1b31e0b@xxxxxxxxxx/T/
>
> Move GB-PC2 specific phy_external node to its own device tree.
>
> Signed-off-by: Arınç ÜNAL <arinc.unal@xxxxxxxxxx>
> ---
>  drivers/staging/mt7621-dts/gbpc2.dts   | 16 +++++++++++-----
>  drivers/staging/mt7621-dts/mt7621.dtsi | 13 +++----------
>  2 files changed, 14 insertions(+), 15 deletions(-)

Reviewed-by: Sergio Paracuellos <sergio.paracuellos@xxxxxxxxx>

Thanks,
    Sergio Paracuellos

>
> diff --git a/drivers/staging/mt7621-dts/gbpc2.dts b/drivers/staging/mt7621-dts/gbpc2.dts
> index 6fe603c7711d..03d6bb6735ac 100644
> --- a/drivers/staging/mt7621-dts/gbpc2.dts
> +++ b/drivers/staging/mt7621-dts/gbpc2.dts
> @@ -13,10 +13,16 @@ &default_gpio {
>         function = "gpio";
>  };
>
> -&gmac1 {
> -       status = "ok";
> -};
> +&ethernet {
> +       gmac1: mac@1 {
> +               status = "ok";
> +               phy-handle = <&phy_external>;
> +       };
>
> -&phy_external {
> -       status = "ok";
> +       mdio-bus {
> +               phy_external: ethernet-phy@5 {
> +                       reg = <5>;
> +                       phy-mode = "rgmii-rxid";
> +               };
> +       };
>  };
> diff --git a/drivers/staging/mt7621-dts/mt7621.dtsi b/drivers/staging/mt7621-dts/mt7621.dtsi
> index 489754f6ed77..38ab6447756a 100644
> --- a/drivers/staging/mt7621-dts/mt7621.dtsi
> +++ b/drivers/staging/mt7621-dts/mt7621.dtsi
> @@ -325,6 +325,9 @@ ethernet: ethernet@1e100000 {
>
>                 mediatek,ethsys = <&sysc>;
>
> +               pinctrl-names = "default";
> +               pinctrl-0 = <&rgmii1_pins &rgmii2_pins &mdio_pins>;
> +
>                 gmac0: mac@0 {
>                         compatible = "mediatek,eth-mac";
>                         reg = <0>;
> @@ -342,22 +345,12 @@ gmac1: mac@1 {
>                         reg = <1>;
>                         status = "off";
>                         phy-mode = "rgmii-rxid";
> -                       phy-handle = <&phy_external>;
>                 };
>
>                 mdio-bus {
>                         #address-cells = <1>;
>                         #size-cells = <0>;
>
> -                       phy_external: ethernet-phy@5 {
> -                               status = "off";
> -                               reg = <5>;
> -                               phy-mode = "rgmii-rxid";
> -
> -                               pinctrl-names = "default";
> -                               pinctrl-0 = <&rgmii2_pins>;
> -                       };
> -
>                         switch0: switch0@0 {
>                                 compatible = "mediatek,mt7621";
>                                 reg = <0>;
> --
> 2.25.1
>