Hi Dan,
On 1/25/22 15:59, Dan Carpenter wrote:
On Tue, Jan 25, 2022 at 03:48:32PM +0300, Pavel Skripkin wrote:
Hi Phillip,
On 1/25/22 01:44, Phillip Potter wrote:
> Remove all DBG_88E calls from the os_dep directory, other than those in
> os_dep/ioctl_linux.c, as this contains almost 200 on its own so will be
> done in a separate patch for ease of review. These calls do not conform
> to kernel coding standards and are superfluous. Also restructure where
> appropriate to remove no longer needed code left behind by removal of
> these calls. This will allow the eventual removal of the DBG_88E macro
> itself.
>
> Signed-off-by: Phillip Potter <phil@xxxxxxxxxxxxxxxx>
> ---
[code snip]
> - /* 2012-07-11 Move here to prevent the 8723AS-VAU BT auto
> - * suspend influence */
> - if (usb_autopm_get_interface(pusb_intf) < 0)
> - DBG_88E("can't get autopm:\n");
> -
Didn't you make a function change here? I didn't test and also didn't find
any mentions of tests in cover letter.
It is obviously a bug. Please avoid ask rhetorical questions or someone
will answer them.
It isn't so obvious for me. Might be Phillip knows something about
8723AS-VAU BT (whatever it is) issue.
I prefer not to say "it's an error", when I am not 100% sure :)
With regards,
Pavel Skripkin
