Re: [PATCH 09/10] staging: r8188eu: remove the private "test" ioctl

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Martin Kaiser <martin@xxxxxxxxx>
Subject: Re: [PATCH 09/10] staging: r8188eu: remove the private "test" ioctl
From: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Date: Thu, 6 Jan 2022 11:52:03 +0300
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Larry Finger <Larry.Finger@xxxxxxxxxxxx>, Phillip Potter <phil@xxxxxxxxxxxxxxxx>, Michael Straube <straube.linux@xxxxxxxxx>, linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20211226212535.197989-10-martin@kaiser.cx>
References: <20211226212535.197989-1-martin@kaiser.cx> <20211226212535.197989-10-martin@kaiser.cx>
User-agent: Mutt/1.9.4 (2018-02-28)

On Sun, Dec 26, 2021 at 10:25:34PM +0100, Martin Kaiser wrote:
> Remove the private "test" ioctl. It copies data from user space,
> this data is not used.

It also had some memory corruption bugs because of the lack of NUL
termination.

regards,
dan carpenter

References:
- [PATCH 00/10] staging: r8188eu: clean up private ioctls
  - From: Martin Kaiser
- [PATCH 09/10] staging: r8188eu: remove the private "test" ioctl
  - From: Martin Kaiser

Prev by Date: Re: [PATCH] qlge: refactor qlge_change_rx_buffers() in qlge_main.c
Next by Date: [PATCH] staging: kpc2000: kpc2000_spi: Check for null pointer after calling devm_ioremap
Previous by thread: [PATCH 09/10] staging: r8188eu: remove the private "test" ioctl
Next by thread: [PATCH 10/10] staging: r8188eu: remove unused prototype
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux