Re: [PATCH] qlge: refactor qlge_change_rx_buffers() in qlge_main.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 28, 2021 at 04:57:56PM +0300, Adam Kandur wrote:
> I assume this can be written using for loop instead of while,
> wich looks nicer for me.

The original code was better than your code.

Also we have a published style guidelines.  We don't really encourage
people to start enforcing their own weird style preferences which are
not in the style guidelines.  Once you are a maintainer then no one can
stop you from having opinions but until then it's best to stick to the
style guideline.

regards,
dan carpenter





[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux