Re: [PATCH v3 4/7] staging: r8188eu: bAPKThermalMeterIgnore is set but never used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thus wrote Michael Straube (straube.linux@xxxxxxxxx):

> The field bAPKThermalMeterIgnore of struct hal_data_8188e is set but
> never used. Remove it.

> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
> ---
> v3: no changes
> v2: no changes

>  drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 5 ++---
>  drivers/staging/r8188eu/include/rtl8188e_hal.h  | 1 -
>  2 files changed, 2 insertions(+), 4 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> index 065c2701077d..cce291ca44b1 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> @@ -1230,9 +1230,8 @@ void Hal_ReadThermalMeter_88E(struct adapter *Adapter, u8 *PROMContent, bool Aut
>  	else
>  		pHalData->EEPROMThermalMeter = EEPROM_Default_ThermalMeter_88E;

> -	if (pHalData->EEPROMThermalMeter == 0xff || AutoloadFail) {
> -		pHalData->bAPKThermalMeterIgnore = true;
> +	if (pHalData->EEPROMThermalMeter == 0xff || AutoloadFail)
>  		pHalData->EEPROMThermalMeter = EEPROM_Default_ThermalMeter_88E;
> -	}
> +
>  	DBG_88E("ThermalMeter = 0x%x\n", pHalData->EEPROMThermalMeter);
>  }
> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index de58c85b8bdc..40b3db34b8f2 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -181,7 +181,6 @@ struct hal_data_8188e {
>  	u8	EEPROMRegulatory;

>  	u8	EEPROMThermalMeter;
> -	u8	bAPKThermalMeterIgnore;

>  	bool	EepromOrEfuse;

> -- 
> 2.34.1

Acked-by: Martin Kaiser <martin@xxxxxxxxx>




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux