Re: [PATCH v3 3/7] staging: r8188eu: bTXPowerDataReadFromEEPORM is set but never used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thus wrote Michael Straube (straube.linux@xxxxxxxxx):

> The field bTXPowerDataReadFromEEPORM of struct hal_data_8188e is set
> but never used. Remove it.

> Signed-off-by: Michael Straube <straube.linux@xxxxxxxxx>
> ---
> v3: no changes
> v2: no changes

>  drivers/staging/r8188eu/hal/rtl8188e_hal_init.c | 3 ---
>  drivers/staging/r8188eu/include/rtl8188e_hal.h  | 1 -
>  2 files changed, 4 deletions(-)

> diff --git a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> index d8d6547465a7..065c2701077d 100644
> --- a/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> +++ b/drivers/staging/r8188eu/hal/rtl8188e_hal_init.c
> @@ -1127,9 +1127,6 @@ void Hal_ReadTxPowerInfo88E(struct adapter *padapter, u8 *PROMContent, bool Auto

>  	Hal_ReadPowerValueFromPROM_8188E(&pwrInfo24G, PROMContent, AutoLoadFail);

> -	if (!AutoLoadFail)
> -		pHalData->bTXPowerDataReadFromEEPORM = true;
> -
>  	for (ch = 0; ch < CHANNEL_MAX_NUMBER; ch++) {
>  		hal_get_chnl_group_88e(ch, &group);

> diff --git a/drivers/staging/r8188eu/include/rtl8188e_hal.h b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> index 8b54f52f49e2..de58c85b8bdc 100644
> --- a/drivers/staging/r8188eu/include/rtl8188e_hal.h
> +++ b/drivers/staging/r8188eu/include/rtl8188e_hal.h
> @@ -180,7 +180,6 @@ struct hal_data_8188e {
>  	u16	EEPROMSDID;
>  	u8	EEPROMRegulatory;

> -	u8	bTXPowerDataReadFromEEPORM;
>  	u8	EEPROMThermalMeter;
>  	u8	bAPKThermalMeterIgnore;

> -- 
> 2.34.1

Acked-by: Martin Kaiser <martin@xxxxxxxxx>




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux