On Sat, Nov 06, 2021 at 11:17:44PM +0100, Fabio M. De Francesco wrote: > On Saturday, November 6, 2021 8:26:35 PM CET Pavel Skripkin wrote: > > > > We need to review code better to prevent accidentally regressions > > > > Thanks for bisection and your report > > > Hello everybody, > > I've just read this thread and I'm sorry for introducing a regression with > commit 221abd4d478a ("staging: r8188eu: Remove no more necessary definitions > and code"). > Dear Fabio, This is an honest mistake, and you shouldn't worry - anyone of us could have done the same thing. You have contributed hugely to this driver, and we are all better off as a community for it :-) Even with all of us checking each others code, things like this will slip through, this is just the nature of the process. We are all human after all. I am looking forward to seeing more of your excellent work! :-) Regards, Phil