On Saturday, November 6, 2021 8:26:35 PM CET Pavel Skripkin wrote:
>
> We need to review code better to prevent accidentally regressions
>
> Thanks for bisection and your report
>
Hello everybody,
I've just read this thread and I'm sorry for introducing a regression with
commit 221abd4d478a ("staging: r8188eu: Remove no more necessary definitions
and code").
Anyway, thanks to Zameer for reporting this issue and thanks to Larry for the
fix :)
These are the output of my tests without Larry's fix:
localhost:~ # iwlist wlp0s20u1 channel
wlp0s20u1 14 channels in total; available frequencies :
Channel 01 : 2.412 GHz
Channel 02 : 2.417 GHz
Channel 03 : 2.422 GHz
Channel 04 : 2.427 GHz
Channel 05 : 2.432 GHz
Channel 06 : 2.437 GHz
Channel 07 : 2.442 GHz
Channel 08 : 2.447 GHz
Channel 09 : 2.452 GHz
Channel 10 : 2.457 GHz
Channel 11 : 2.462 GHz
Channel 12 : 2.467 GHz
Channel 13 : 2.472 GHz
Channel 14 : 2.484 GHz
Current Frequency:2.462 GHz (Channel 11)
localhost:~ # iwlist wlp0s20u1 scanning | grep Channel
Frequency:2.462 GHz (Channel 11)
Frequency:2.422 GHz (Channel 3)
Frequency:2.427 GHz (Channel 4)
It can scan the only three cells that are reachable from my current position
and it seems that all 14 channels are up and working.
I see that Larry fills the elements of the array that I left empty. I can't
still understand why this driver works for everybody else but not for Zameer.
However, even if the users do something unusual or have weird configurations,
I believe that drivers should be resilient and keep working properly.
Therefore, it's for sure a regression and so it must be fixed. I'm happy that
Zameer noticed it and helped with bisecting, and that Larry found soon the
roots of the problem and fixed it.
Again, thanks to you all,
Fabio
