Hi, On 10/3/21 6:18 PM, Saurav Girepunje wrote: > Remove reassignment of same value to variable pstat->auth_seq. > On if (seq == 1) assigning the value 2. At the end of if statement > also assigning the value pstat->auth_seq = seq + 1 that is again > assigning the value 2. > > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx> > --- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > index 3ee4d35ca8d7..059cd85f4b03 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > @@ -808,7 +808,6 @@ unsigned int OnAuth(struct adapter *padapter, union recv_frame *precv_frame) > pstat->state &= ~WIFI_FW_AUTH_NULL; > pstat->state |= WIFI_FW_AUTH_STATE; > pstat->authalg = algorithm; > - pstat->auth_seq = 2; Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > } else if (seq == 3) { > > p = rtw_get_ie(pframe + WLAN_HDR_A3_LEN + 4 + _AUTH_IE_OFFSET_, WLAN_EID_CHALLENGE, (int *)&ie_len, > -- > 2.32.0 >