Hi, On 10/3/21 5:58 PM, Saurav Girepunje wrote: > Remove condition which never get execute. > as pattrib->mdata is always zero before if condition check. > > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx> Thanks, patch looks good to me: Reviewed-by: Hans de Goede <hdegoede@xxxxxxxxxx> Regards, Hans > --- > drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > index b2c042c36777..3ee4d35ca8d7 100644 > --- a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > +++ b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c > @@ -3222,9 +3222,6 @@ static int _issue_qos_nulldata(struct adapter *padapter, unsigned char *da, > else if ((pmlmeinfo->state&0x03) == WIFI_FW_STATION_STATE) > SetToDs(fctrl); > > - if (pattrib->mdata) > - SetMData(fctrl); > - > qc = (unsigned short *)(pframe + pattrib->hdrlen - 2); > > SetPriority(qc, tid); > -- > 2.32.0 >