On Sat, Aug 28, 2021 at 04:40:45PM +0530, Aakash Hemadri wrote: > Fix sparse warning: > > rtw_br_ext.c:771:84: got restricted __be16 [usertype] payload_len > > rtw_br_ext.c:773:110: warning: incorrect type in argument 2 > (different base types) > > rtw_br_ext.c:773:110: expected int len > > rtw_br_ext.c:773:110: got restricted __be16 [usertype] payload_len > > csum_ipv6_magic and csum_partial expect int len not __be16, use > be16_to_cpu() > > Signed-off-by: Aakash Hemadri <aakashhemadri123@xxxxxxxxx> > --- > drivers/staging/r8188eu/core/rtw_br_ext.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/r8188eu/core/rtw_br_ext.c b/drivers/staging/r8188eu/core/rtw_br_ext.c > index aa56cd1a8490..38f1bd591da9 100644 > --- a/drivers/staging/r8188eu/core/rtw_br_ext.c > +++ b/drivers/staging/r8188eu/core/rtw_br_ext.c > @@ -615,9 +615,9 @@ int nat25_db_handle(struct adapter *priv, struct sk_buff *skb, int method) > struct icmp6hdr *hdr = (struct icmp6hdr *)(skb->data + ETH_HLEN + sizeof(*iph)); > hdr->icmp6_cksum = 0; > hdr->icmp6_cksum = csum_ipv6_magic(&iph->saddr, &iph->daddr, > - iph->payload_len, > + be16_to_cpu(iph->payload_len), > IPPROTO_ICMPV6, > - csum_partial((__u8 *)hdr, iph->payload_len, 0)); > + csum_partial((__u8 *)hdr, be16_to_cpu(iph->payload_len), 0)); > } > } > } > -- > 2.32.0 > Same question here, does this mean the driver is broken on little-endian systems today? This should be tested... thanks, greg k-h
