On Sat, Aug 28, 2021 at 02:37:26PM +0300, Kari Argillander wrote: > [PATCH v5 2/3] staging: r8188eu: incorrect type in csum_ipv6_magic > > Subject should start with imperative mood. Every patch in this series > needs this fix. > > I actually check linux coding style and did not found mention about > this, but if you look kernel log then you see that it is at least > unwritten rule. You can check this if you want > https://chris.beams.io/posts/git-commit/#imperative The imperitive rule is stupid. We're dealing with thousands of people and lots of them don't speak English as a first language and it's hard to write commit messages. Let's not make it harder than it already is. If you look through the commit messages on this list people are like. "Blah blah blah. Fix it!" I like that approach because it shows how humanity can triumph over pointless beaucrats. But in terms of understanding the commit adding "Fix it!" doesn't add any value. The only thing which matters if if the commit message has the correct information in an understandable way. regards, dan carpenter
