On Tuesday, August 17, 2021 7:55:36 PM CEST Greg Kroah-Hartman wrote: > On Mon, Aug 16, 2021 at 07:51:38PM +0200, Fabio M. De Francesco wrote: > > Remove all the code related to the management of the NAT25_LOOKUP > > method in nat25_db_handle(). The only function that used that method was > > the now deleted nat25_handle_frame(). Remove the NAT25_LOOKUP entry from > > the NAT25_METHOD enum because it is not anymore used everywhere else in > > the code of the driver. > > > > Signed-off-by: Fabio M. De Francesco <fmdefrancesco@xxxxxxxxx> > > --- > > > > v2: Patch rebased against the latest Greg K-H's tree. > > > > drivers/staging/r8188eu/core/rtw_br_ext.c | 112 ------------------- > > drivers/staging/r8188eu/include/rtw_br_ext.h | 1 - > > 2 files changed, 113 deletions(-) > > This change adds a build warning, which is not allowed. > > Please merge this, and the 3/3 patch into a single change, so that it > all is removed together, causing no build warnings at any point in time. Sorry, I didn't know that, within a series, no patch is allowed to add build warning that are then fixed by the following ones. I did it for the purpose of splitting different logical changes into different patches and the removal of code related to NAT25_LOOKUP (2/3) introduced some warnings about a function and a variable that were not anymore used. Patch 3/3 had the changes that removed the above-mentioned no more used objects. According to your request, now I've merged 2/3 and 3/3 into a single v3 patch. I had to drop the numbering of the patch because neither 2/3 or 2/2 seemed appropriate to me after the merge. I hope it was the right thing to do. If not, let me know, please. Please see: https://lore.kernel.org/lkml/20210817185723.15192-1-fmdefrancesco@xxxxxxxxx Thanks, Fabio > thanks, > > greg k-h >
