On Fri, Jul 16, 2021 at 8:45 AM Mauro Carvalho Chehab
<mchehab+huawei@xxxxxxxxxx> wrote:
>
> Em Wed, 14 Jul 2021 07:36:43 -0600
> Rob Herring <robh@xxxxxxxxxx> escreveu:
>
> > On Wed, Jul 14, 2021 at 3:13 AM Mauro Carvalho Chehab
> > <mchehab+huawei@xxxxxxxxxx> wrote:
> > >
> > > Instead of using the standard name ("gpios"), use "interrupts".
> > >
> > > Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> > > Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> > > ---
> > > drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 2 +-
> > > drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 4 ++--
> > > 2 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> > > index 35ef3d4c760b..9a7e095246f7 100644
> > > --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> > > +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> > > @@ -233,7 +233,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
> > >
> > > ddata->dev = dev;
> > >
> > > - ddata->gpio = of_get_gpio(np, 0);
> > > + ddata->gpio = of_get_named_gpio_flags(np, "interrupts", 0, NULL);
> >
> > It's an interrupt, you should be using platform_get_irq() and
> > devm_request_irq().
> >
> > In general, you should not be using of_get_* for any resources, but
> > use the firmware agnostic flavors.
>
> I've no idea how to convert to use platform_get_irq().
>
> I tried to replace the logic:
>
> priv->gpio = of_get_gpio(np, 0);
> if (priv->gpio < 0)
> return priv->gpio;
>
> if (!gpio_is_valid(priv->gpio))
> return -EINVAL;
>
> ret = devm_gpio_request_one(dev, priv->gpio, GPIOF_IN, "pmic");
> if (ret < 0) {
> dev_err(dev, "Failed to request gpio%d\n", priv->gpio);
> return ret;
> }
>
> Into:
>
> priv->irq = platform_get_irq(pdev, 0);
>
> But it didn't work (I also tried the platform_get_irq_byname):
>
> [ 1.109586] hi6421v600-irq hi6421v600-irq: hi6421v600_irq_probe:
> [ 1.115676] hi6421v600-irq hi6421v600-irq: IRQ index 0 not found
> [ 1.121751] hi6421v600-irq hi6421v600-irq: Error -6 when getting IRQs
>
> The original DT schema as:
>
> gpios = <&gpio28 0 0>;
>
> Based on your past review, this was replaced by:
>
> interrupts = <&gpio28 0 0>;
>
>
> What am I missing?
'interrupts' doesn't take a phandle. You need:
interrupts = <0 0>;
interrupt-parent = <&gpio28>;
You should have been getting dtc warnings that this was wrong.
Rob
