On Wed, Jul 14, 2021 at 3:13 AM Mauro Carvalho Chehab
<mchehab+huawei@xxxxxxxxxx> wrote:
>
> Instead of using the standard name ("gpios"), use "interrupts".
>
> Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> ---
> drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 2 +-
> drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml | 4 ++--
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> index 35ef3d4c760b..9a7e095246f7 100644
> --- a/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> +++ b/drivers/staging/hikey9xx/hi6421-spmi-pmic.c
> @@ -233,7 +233,7 @@ static int hi6421_spmi_pmic_probe(struct spmi_device *pdev)
>
> ddata->dev = dev;
>
> - ddata->gpio = of_get_gpio(np, 0);
> + ddata->gpio = of_get_named_gpio_flags(np, "interrupts", 0, NULL);
It's an interrupt, you should be using platform_get_irq() and
devm_request_irq().
In general, you should not be using of_get_* for any resources, but
use the firmware agnostic flavors.
> if (ddata->gpio < 0)
> return ddata->gpio;
>
> diff --git a/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml b/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml
> index 8e355cddd437..252b600f02a8 100644
> --- a/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml
> +++ b/drivers/staging/hikey9xx/hisilicon,hi6421-spmi-pmic.yaml
> @@ -34,7 +34,7 @@ properties:
>
> interrupt-controller: true
>
> - gpios:
> + interrupts:
> maxItems: 1
> description: GPIO used for IRQs
>
> @@ -71,7 +71,7 @@ examples:
>
> #interrupt-cells = <2>;
> interrupt-controller;
> - gpios = <&gpio28 0 0>;
> + interrupts = <&gpio28 0 0>;
>
> regulators {
> #address-cells = <1>;
> --
> 2.31.1
>
