On Tue, Jun 08, 2021 at 09:45:49AM -0700, Joe Perches wrote: > On Tue, 2021-06-08 at 16:12 +0200, Greg Kroah-Hartman wrote: > > On Tue, Jun 08, 2021 at 10:16:20PM +0800, Liu Shixin wrote: > > > Use eth_broadcast_addr() to assign broadcast address. > > > > That says what you do, but not _why_ you are doing this? > > > > Why make this change? What benifit does it provide? > > The commit message is clear and concise as using available kernel > mechanisms is better than homegrown or duplicative ones. > > Are you asking merely becuse Liu Shixin hasn't had many staging > commits? I'm asking because this changelog text does not explain why this is needed at all and needs to be changed to do so. thanks, greg k-h
