Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Liu Shixin <liushixin2@xxxxxxxxxx>
Subject: Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address
From: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 8 Jun 2021 16:12:15 +0200
Cc: linux-staging@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20210608141620.525521-1-liushixin2@huawei.com>
References: <20210608141620.525521-1-liushixin2@huawei.com>

On Tue, Jun 08, 2021 at 10:16:20PM +0800, Liu Shixin wrote:
> Use eth_broadcast_addr() to assign broadcast address.

That says what you do, but not _why_ you are doing this?

Why make this change?  What benifit does it provide?

thanks,

greg k-h

Follow-Ups:
- Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address
  - From: Joe Perches

References:
- [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address
  - From: Liu Shixin

Prev by Date: [PATCH -next 1/2] staging: r8188eu: use is_{zero/broadcast}_ether_addr() instead of memcmp()
Next by Date: Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address
Previous by thread: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address
Next by thread: Re: [PATCH -next 2/2] staging: r8188eu: use eth_broadcast_addr() to assign broadcast address
Index(es):
- Date
- Thread

[Index of Archives] [Linux Driver Development] [Linux Driver Backports] [DMA Engine] [Linux GPIO] [Linux SPI] [Video for Linux] [Linux USB Devel] [Linux Coverity] [Linux Audio Users] [Linux Kernel] [Linux SCSI] [Yosemite Backpacking]

Powered by Linux