On Fri, May 14, 2021 at 08:56:10AM -0700, Joe Perches wrote: > On Fri, 2021-05-14 at 17:30 +0200, Greg KH wrote: > > On Fri, May 14, 2021 at 08:42:16PM +0530, Shreyansh Chouhan wrote: > [] > > > I didn't look at how/where was the macro called and missed a very > > > obvious error. Now that I have looked at it, the only way I can think of > > > fixing this is changing the macro to a (inline?) function. Will > > > that be a desirable change? > > > > No, it can't be a function, the code is fine as-is, checkpatch is just a > > perl script and does not always know what needs to be done. > > true. > > perhaps better though to rename these declaring macros to start with declare_ > > Something like this: Thanks! I can definitely help with this. I'll send the patch in a bit. Since it seemed as if the original patch wasn't really required, I canceled the moderator approval request for the greybus-dev mailing list. I thought I'd rather not bother the moderator and the rest of the list with these patches. I thought I should mention this since it could cause some confusion. I will start a new thread for the other patch. Regards, Shreyansh Chouhan
