On Thu, May 06, 2021 at 05:25:43PM +0200, Mauro Carvalho Chehab wrote: > @@ -1069,11 +1071,19 @@ static int tegra_vde_probe(struct platform_device *pdev) > * power-cycle it in order to put hardware into a predictable lower > * power state. > */ > - pm_runtime_get_sync(dev); > + if (pm_runtime_resume_and_get(dev) < 0) > + goto err_pm_runtime; Needs an error code on this path. These days the kbuild bot will send a warning for this eventually. > + > pm_runtime_put(dev); > > return 0; > > +err_pm_runtime: > + misc_deregister(&vde->miscdev); > + > + pm_runtime_dont_use_autosuspend(dev); > + pm_runtime_disable(dev); > + > err_deinit_iommu: > tegra_vde_iommu_deinit(vde); > regards, dan carpenter
