The subject doesn't make sense.
> -/*
> - * Configure the 6 FIFO's that are used by the network accelarator to
> +/**
> + * xlr_config_fifo_spill_area() - Configure the 6 FIFO's that are used by the network accelarator to
This comment is way too long now. For comments, we want to be within
the 80 character limit.
> * communicate with the rest of the XLx device. 4 of the FIFO's are for
> * packets from NA --> cpu (called Class FIFO's) and 2 are for feeding
> * the NA with free descriptors.
> @@ -440,8 +439,8 @@ static void xlr_config_fifo_spill_area(struct xlr_net_priv *priv)
[ snip ]
> @@ -599,7 +600,7 @@ static int xlr_phy_write(u32 *base_addr, int phy_addr, int regnum, u16 val)
> unsigned long timeout, stoptime, checktime;
> int timedout;
>
> - /* 100ms timeout*/
> +
> timeout = msecs_to_jiffies(100);
This patch introduces a double blank line checkpatch warning.
> stoptime = jiffies + timeout;
> timedout = 0;
> @@ -629,7 +630,7 @@ static int xlr_phy_read(u32 *base_addr, int phy_addr, int regnum)
> unsigned long timeout, stoptime, checktime;
> int timedout;
>
> - /* 100ms timeout*/
> +
> timeout = msecs_to_jiffies(100);
Same.
> stoptime = jiffies + timeout;
> timedout = 0;
[ snip ]
> @@ -951,9 +954,7 @@ static int xlr_net_probe(struct platform_device *pdev)
> int err, port;
>
> pr_info("XLR/XLS Ethernet Driver controller %d\n", pdev->id);
> - /*
> - * Allocate our adapter data structure and attach it to the device.
> - */
> + /* Allocate our adapter data structure and attach it to the device.*/
There needs to be a space before the "*/" closing.
> adapter = devm_kzalloc(&pdev->dev, sizeof(*adapter), GFP_KERNEL);
> if (!adapter)
> return -ENOMEM;
regards,
dan carpenter
