Re: [PATCH] netlogic: This patch formats existing comments to Linux standards found in TODO.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 03, 2021 at 05:03:53PM +0000, Jordan Vaughn wrote:
> Netlogic: xlr_net: Fix styling problems with comments 
> 
> Signed-off-by: Jordan Vaughn <jordvaughn1@xxxxxxxxx>
> ---
>  drivers/staging/netlogic/xlr_net.c | 67 +++++++++++++++---------------
>  drivers/staging/netlogic/xlr_net.h |  3 +-
>  2 files changed, 36 insertions(+), 34 deletions(-)
> 
> diff --git a/drivers/staging/netlogic/xlr_net.c b/drivers/staging/netlogic/xlr_net.c
> index 69ea61faf8fa..c1539b6b75b8 100644
> --- a/drivers/staging/netlogic/xlr_net.c
> +++ b/drivers/staging/netlogic/xlr_net.c
> @@ -15,20 +15,19 @@
>  #include <linux/jiffies.h>
>  #include <linux/interrupt.h>
>  #include <linux/platform_device.h>
> -

This was not a comment change :(

And please write a better changelog.

>  #include <asm/mipsregs.h>
> -/*
> +
> +/**

That's a kernel-doc format marker, why did you do that?

thanks,

greg k-h




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux