Re: [PATCH 0/5] staging: comedi: tests: Fix various issues

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/04/2021 16:48, Spencer Olson wrote:
On Wed, Apr 7, 2021 at 9:39 AM Ian Abbott <abbotti@xxxxxxxxx> wrote:
The "ni_routes_test" module in "drivers/staging/comedi/drivers/test/"
would need a new config option because it will need to either depend on
or select the COMEDI_NI_ROUTING option.  The "example_test" module (crap
name) in the same directory doesn't depend on anything in particular.

I don't have any arguments against your complaint of the
"example_test" name :-).  It was written with the hope that more parts
of comedi might follow suit and create some unit tests.  In terms of
placement in the tree, I had been following a pattern set by another
module that also had some unit tests contained local to the module's
directory (can't remember now which one it was).

I might as well rename it to "comedi_example_test" then.

--
-=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company  )=-
-=( registered in England & Wales.  Regd. number: 02862268.  )=-
-=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
-=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-




[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux