On Wed, Apr 7, 2021 at 9:39 AM Ian Abbott <abbotti@xxxxxxxxx> wrote:
>
> On 07/04/2021 16:10, Greg Kroah-Hartman wrote:
> > On Wed, Apr 07, 2021 at 03:01:37PM +0100, Ian Abbott wrote:
> >> The code under "drivers/staging/comedi/drivers/tests/" is built when the
> >> CONFIG_COMEDI_TESTS option is enabled. That currently needs to be done
> >> on the "make" command line since the option does not appear in the
> >> Kconfig files.
> >>
> >> This patch series fixes a compilation error and various other niggles
> >> including checkpatch.pl stuff.
> >>
> >> 1) staging: comedi: tests: ni_routes_test: Fix compilation error
> >> 2) staging: comedi: tests: ni_routes_test: Put complex values in parentheses
> >> 3) staging: comedi: tests: ni_routes_test: Avoid CamelCase: <RVi>
> >> 4) staging: comedi: tests: ni_routes_test: Lines should not end with a '('
> >> 5) staging: comedi: tests: Correct unittest_fptr
> >
> > Should we move these to the normal kernel testing directory instead, so
> > that they do get some build testing?
>
> I'm not sure since they are in "drivers/staging". However, we could add
> something to comedi's Kconfig to allow the tests to be built.
>
> The "ni_routes_test" module in "drivers/staging/comedi/drivers/test/"
> would need a new config option because it will need to either depend on
> or select the COMEDI_NI_ROUTING option. The "example_test" module (crap
> name) in the same directory doesn't depend on anything in particular.
>
> --
> -=( Ian Abbott <abbotti@xxxxxxxxx> || MEV Ltd. is a company )=-
> -=( registered in England & Wales. Regd. number: 02862268. )=-
> -=( Regd. addr.: S11 & 12 Building 67, Europa Business Park, )=-
> -=( Bird Hall Lane, STOCKPORT, SK3 0XA, UK. || www.mev.co.uk )=-
I don't have any arguments against your complaint of the
"example_test" name :-). It was written with the hope that more parts
of comedi might follow suit and create some unit tests. In terms of
placement in the tree, I had been following a pattern set by another
module that also had some unit tests contained local to the module's
directory (can't remember now which one it was).
Spencer
