On Tue, Apr 06, 2021 at 11:36:41AM +0200, Greg KH wrote: > On Tue, Apr 06, 2021 at 02:18:41AM -0700, Pavle Rohalj wrote: > > - struct dvi_ctrl_device *pCurrentDviCtrl; > > + struct dvi_ctrl_device *p_current_dvi_ctrl; > > Does this change make sense? Why keep the "p_" here? We do not need or > use, this type of variable naming in the kernel. > > Also, please break this up into a patch series where you do one > structure change at a time. > > thanks, > > greg k-h Thank you for the input. Makes sense why we would not want to include type information in variable names. I will send a patchset with changes broken up into smaller chunks soon. -Pavle