On Fri, Apr 02, 2021 at 07:29:43PM +0200, Fabio Aiuto wrote: > remove all RT_TRACE logs > I don't mean to be a pain, but this changelog text needs some work. This says _what_ it does, but not _why_ you are doing this. The kernel documentation has a section on how to write a good changelog text, you might want to look at that. For this type of series, this could be as simple as: Remove all of the RT_TRACE_LOGs in the rtx_xmit.c file as they currently do nothing as they require the code to be modified by hand in order to be turned on. This obviously has not happened since the code was merged, so just remove them as they are unused. Or something like that. Most of the time, writing the changelog can take more work than the actual code change itself, but it's important as we need to know what is happening both for the reviewers, as well as people in the future who might have to look back and try to understand the reason for specific changes. Can you fix up this series based on this and resend? thanks, greg k-h
