On Fri, Apr 02, 2021 at 11:37:17AM -0700, Joe Perches wrote: > On Fri, 2021-04-02 at 19:40 +0200, Fabio Aiuto wrote: > > On Fri, Apr 02, 2021 at 08:20:17AM -0700, Joe Perches wrote: > > > On Fri, 2021-04-02 at 14:51 +0200, Fabio Aiuto wrote: > > > > On Fri, Apr 02, 2021 at 03:37:57AM -0700, Joe Perches wrote: > > > > > On Fri, 2021-04-02 at 12:01 +0200, Fabio Aiuto wrote: > > > > > > remove all RT_TRACE logs > > > > > > > > > > > > fix patch-related checkpatch issues > [] > > > > > Lastly, another suggestion would be to just submit a single patch > > > > > removing _ALL_ the RT_TRACE uses not intermixing various other cleanups > > > > > with the series and then do those other cleanups. > > > > > > > > > > Using a coccinelle script like: > > > > > > > > > > $ cat RT_TRACE.cocci > > > > > @@ > > > > > expression a, b, c; > > > > > @@ > > > > > > > > > > - RT_TRACE(a, b, (c)); > > > > > > > > > > $ spatch -sp-file RT_TRACE.cocci drivers/staging/rtl8723bs/ > > > > > > > > > > And then clean up the various bits you think are inappropriately done. > [] > > > > thank you Joe, I tried with (RT_TRACE.cocci in parent folder) > > > > > > > > user@host:~/src/git/kernels/staging$ spatch -sp-file ../RT_TRACE.cocci drivers/staging/rtl8723bs/ > > > > init_defs_builtins: /usr/local/bin/../lib/coccinelle/standard.h > > > > 0 files match > > > > > > Likely you are running the script on the tree after you have > > > applied all your patches. > > > > > > Try running the cocci script on a fresh copy of -next. > > > > > > Using the script and adding the script in the commit message helps > > > others to verify that the changes you make do not have any other effect. > > > > > > $ cat RT_TRACE.cocci > > > @@ > > > expression a, b, c; > > > @@ > > > > > > - RT_TRACE(a, b, (c)); > > > > > > $ git checkout next-20210401 > > > $ spatch -sp-file RT_TRACE.cocci --in-place --no-show-diff --very-quiet drivers/staging/rtl8723bs/ > > > 31 files match > > > $ git diff --stat -p > > > drivers/staging/rtl8723bs/core/rtw_cmd.c | 34 +------ > [] > > > 28 files changed, 19 insertions(+), 935 deletions(-) > [] > > thank you Joe, this mail is so precious ;) > > I'm not quite sure what you mean by that but you quoted > nearly 200k of the previous email. you gave me good advice > > Please remember to trim your replies. > > got it, thank you regards, fabio
