On Wed, Mar 24, 2021 at 04:42:45PM +0300, Dan Carpenter wrote:
> On Wed, Mar 24, 2021 at 01:44:24PM +0100, Marco Cesati wrote:
> > Remove the following unnecessary enum names or definitions in
> > include/rtw_mlme.h:
> >
> > enum dot11AuthAlgrthmNum [name]
> > enum _band [name]
>
> Sorry, I was unclear. I liked the names fine, it just that _band was a
> bad name. It's too vague and what's with the underscore character?
So, just to be sure, beside the singular case "_band", are you objecting
to remove the names of the enums that are never referenced in the code?
That is, to transform "enum XXX { ... };" into "enum { ... };", as long
as "XXX" is not used elsewhere.
>
> > enum DriverInterface [definition]
> > enum scan_result_type [definition]
>
> These are good to delete. And it wouldn't surprise me if you found a
> bunch of these enums were duplicates of more standard global enums.
OK. Thank you,
Marco
>
> regards,
> dan carpenter
>
>
--
----
Marco Cesati, PhD
Dept. of Civil Engineering and Computer Science Engineering
Univ. of Rome Tor Vergata
via del Politecnico 1, I-00133 Rome, Italy
Tel. +39 06 7259 7389
