Re: [PATCH 01/33] Staging: rtl8723bs: remove named enums in rtw_mlme.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 24, 2021 at 01:44:24PM +0100, Marco Cesati wrote:
> Remove the following unnecessary enum names or definitions in
> include/rtw_mlme.h:
> 
> 	enum dot11AuthAlgrthmNum	[name]
> 	enum  _band			[name]

Sorry, I was unclear.  I liked the names fine, it just that _band was a
bad name.  It's too vague and what's with the underscore character?

> 	enum DriverInterface		[definition]
> 	enum scan_result_type		[definition]

These are good to delete.  And it wouldn't surprise me if you found a
bunch of these enums were duplicates of more standard global enums.

regards,
dan carpenter






[Index of Archives]     [Linux Driver Development]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux