Re: [PATCH v2 11/12] dt-bindings: nand: Add fsl,elbc-fcm-nand
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 11/12] dt-bindings: nand: Add fsl,elbc-fcm-nand
- From: "Rob Herring (Arm)" <robh@xxxxxxxxxx>
- Date: Fri, 07 Feb 2025 17:45:00 -0600
- Cc: Nicholas Piggin <npiggin@xxxxxxxxx>, Naveen N Rao <naveen@xxxxxxxxxx>, Vinod Koul <vkoul@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, J. Neuschäfer <j.neuschaefer@xxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Lee Jones <lee@xxxxxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx, Mark Brown <broonie@xxxxxxxxxx>, imx@xxxxxxxxxxxxxxx, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, linux-spi@xxxxxxxxxxxxxxx, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Scott Wood <oss@xxxxxxxxxxxx>, devicetree@xxxxxxxxxxxxxxx, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx, dmaengine@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, Niklas Cassel <cassel@xxxxxxxxxx>
- In-reply-to: <20250207-ppcyaml-v2-11-8137b0c42526@posteo.net>
- References: <20250207-ppcyaml-v2-0-8137b0c42526@posteo.net> <20250207-ppcyaml-v2-11-8137b0c42526@posteo.net>
On Fri, 07 Feb 2025 22:30:28 +0100, J. Neuschäfer wrote:
> Formalize the binding already supported by the fsl_elbc_nand.c driver
> and used in several device trees in arch/powerpc/boot/dts/.
>
> Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx>
> ---
>
> V2:
> - split out from fsl,elbc binding patch
> - constrain #address-cells and #size-cells
> - add a general description
> - use unevaluatedProperties=false instead of additionalProperties=false
> - fix property order to comply with dts coding style
> - include raw-nand-chip.yaml instead of nand-chip.yaml
> ---
> .../devicetree/bindings/mtd/fsl,elbc-fcm-nand.yaml | 68 ++++++++++++++++++++++
> 1 file changed, 68 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mtd/fsl,elbc-fcm-nand.example.dtb: nand@1,0: $nodename:0: 'nand@1,0' does not match '^nand@[a-f0-9]$'
from schema $id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml#
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: nand@1,0: $nodename:0: 'nand@1,0' does not match '^nand@[a-f0-9]$'
from schema $id: http://devicetree.org/schemas/mtd/fsl,elbc-fcm-nand.yaml#
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-ppcyaml-v2-11-8137b0c42526@xxxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|