Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert fsl,elbc to YAML
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 09/12] dt-bindings: memory-controllers: Convert fsl,elbc to YAML
- From: "Rob Herring (Arm)" <robh@xxxxxxxxxx>
- Date: Fri, 07 Feb 2025 17:44:59 -0600
- Cc: Mark Brown <broonie@xxxxxxxxxx>, Damien Le Moal <dlemoal@xxxxxxxxxx>, Conor Dooley <conor+dt@xxxxxxxxxx>, linux-ide@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-crypto@xxxxxxxxxxxxxxx, Vinod Koul <vkoul@xxxxxxxxxx>, dmaengine@xxxxxxxxxxxxxxx, Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, J. Neuschäfer <j.neuschaefer@xxxxxxx>, Guenter Roeck <linux@xxxxxxxxxxxx>, Nicholas Piggin <npiggin@xxxxxxxxx>, Madhavan Srinivasan <maddy@xxxxxxxxxxxxx>, Krzysztof Kozlowski <krzk@xxxxxxxxxx>, Krzysztof Wilczyński <kw@xxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Naveen N Rao <naveen@xxxxxxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, imx@xxxxxxxxxxxxxxx, Niklas Cassel <cassel@xxxxxxxxxx>, Scott Wood <oss@xxxxxxxxxxxx>, Michael Ellerman <mpe@xxxxxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Lorenzo Pieralisi <lpieralisi@xxxxxxxxxx>, Lee Jones <lee@xxxxxxxxxx>, linux-watchdog@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, linux-mtd@xxxxxxxxxxxxxxxxxxx, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx>, Christophe Leroy <christophe.leroy@xxxxxxxxxx>, Wim Van Sebroeck <wim@xxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, linux-pci@xxxxxxxxxxxxxxx
- In-reply-to: <20250207-ppcyaml-v2-9-8137b0c42526@posteo.net>
- References: <20250207-ppcyaml-v2-0-8137b0c42526@posteo.net> <20250207-ppcyaml-v2-9-8137b0c42526@posteo.net>
On Fri, 07 Feb 2025 22:30:26 +0100, J. Neuschäfer wrote:
> Convert the Freescale localbus controller bindings from text form to
> YAML. The updated list of compatible strings reflects current usage
> in arch/powerpc/boot/dts/, except that many existing device trees
> erroneously specify "simple-bus" in addition to fsl,*elbc.
>
> Changes compared to the txt version:
> - removed the board-control (fsl,mpc8272ads-bcsr) node because it only
> appears in this example and nowhere else
> - added a new example with NAND flash
> - updated list of compatible strings
>
> Signed-off-by: J. Neuschäfer <j.ne@xxxxxxxxxx>
> ---
>
> V2:
> - fix order of properties in examples, according to dts coding style
> - move to Documentation/devicetree/bindings/memory-controllers
> - clarify the commit message a tiny bit
> - remove unnecessary multiline markers (|)
> - define address format in patternProperties
> - trim subject line (remove "binding")
> - remove use of "simple-bus", because it's technically incorrect
> ---
> .../bindings/memory-controllers/fsl,elbc.yaml | 146 +++++++++++++++++++++
> .../devicetree/bindings/powerpc/fsl/lbc.txt | 43 ------
> 2 files changed, 146 insertions(+), 43 deletions(-)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-0/localbus@f0010100/simple-periph@2,0: failed to match any schema with compatible: ['fsl,elbc-gpcm-uio']
Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-1/localbus@e0005000/nand@1,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand']
Documentation/devicetree/bindings/memory-controllers/fsl,elbc.example.dtb: /example-1/localbus@e0005000/nand@1,0: failed to match any schema with compatible: ['fsl,mpc8315-fcm-nand', 'fsl,elbc-fcm-nand']
doc reference errors (make refcheckdocs):
Warning: Documentation/devicetree/bindings/display/ssd1289fb.txt references a file that doesn't exist: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt
Documentation/devicetree/bindings/display/ssd1289fb.txt: Documentation/devicetree/bindings/powerpc/fsl/lbc.txt
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250207-ppcyaml-v2-9-8137b0c42526@xxxxxxxxxx
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
[Index of Archives]
[Linux Kernel]
[Linux ARM (vger)]
[Linux ARM MSM]
[Linux Omap]
[Linux Arm]
[Linux Tegra]
[Fedora ARM]
[Linux for Samsung SOC]
[eCos]
[Linux Fastboot]
[Gcc Help]
[Git]
[DCCP]
[IETF Announce]
[Security]
[Linux MIPS]
[Yosemite Campsites]
|