Re: [PATCH] spi: spidev: Align ordering of spidev_spi_ids[] and spidev_dt_ids[]

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Uwe,

On Tue, Dec 17, 2024 at 12:42 PM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxx> wrote:
> There is a 1:1 correspondance between the list of spi device-ids and the
> devicetree compatibles. The latter is ordered alphabetically by vendor
> and device. To simplify keeping the two lists in sync, mention the
> vendor in a comment for the spi device-ids and order alphabetically,
> too.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spidev.c
> +++ b/drivers/spi/spidev.c
> @@ -698,20 +698,24 @@ static const struct class spidev_class = {
>         .name = "spidev",
>  };
>
> +/*
> + * The spi device ids are expected to match the device names of the
> + * spidev_dt_ids array below. Both arrays are kept in the same ordering.
> + */
>  static const struct spi_device_id spidev_spi_ids[] = {
> -       { .name = "bh2228fv" },
> -       { .name = "dh2228fv" },
> -       { .name = "jg10309-01" },
> -       { .name = "ltc2488" },
> -       { .name = "sx1301" },
> -       { .name = "bk4" },
> -       { .name = "bk4-spi" },
> -       { .name = "dhcom-board" },
> -       { .name = "m53cpld" },
> -       { .name = "spi-petra" },
> -       { .name = "spi-authenta" },
> -       { .name = "em3581" },
> -       { .name = "si3210" },
> +       { .name = /* cisco */ "spi-petra" },

Pity we can't use

     { .name = strchr("cisco,spi-petra", ',') + 1 },

else we could do some macros on top to keep the tables in sync...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds