Re: [PATCH] spi: Fix acpi deferred irq probe

[Hans de Goede <hdegoede@xxxxxxxxxx>]

Hi Alexis,

On 24-Nov-24 8:23 PM, Alexis Lothoré wrote:
> Hello,
> 
> owning a Dell XPS 9320 and struggling to make the freshly merged IPU6
> support to work on it, I was about to send a call for help on the media ML,
> when I eventually spotted your observations on Redhat's bugzilla ([0]), and
> this corresponding patch.
> 
> On Fri Nov 22, 2024 at 10:42 AM CET, Stanislaw Gruszka wrote:
>> When probing spi device take care of deferred probe of ACPI irq gpio
>> similar like for OF/DT case.
>>
>> From practical standpoint this fixes issue with vsc-tp driver on
>> Dell XP 9340 laptop, which try to request interrupt with spi->irq
>> equal to -EPROBE_DEFER and fail to probe with the following error:
>>
>> vsc-tp spi-INTC10D0:00: probe with driver vsc-tp failed with error -22
>>
>> Suggested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
>> Fixes: 33ada67da352 ("ACPI / spi: attach GPIO IRQ from ACPI description to SPI device")
>> Cc: stable@xxxxxxxxxxxxxxx
>> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>
> 
> [...]
> 
> I systematically observe this issue (probe failure with -22) on each boot,
> and reached the same intermediate conclusion (IRQ failing to register, and
> spi->irq value being -EPROBE_DEFER).
> I can confirm that this patch makes the vsc-tp -22 error disappear on my
> machine, and that I have now /sys/devices/platform/intel_vsc.
> 
> Unfortunately, I now encounter a new issue preventing the camera to work
> (ipu6 still fails with -EPROBE_DEFER, I now have
> ipu_bridge_get_ivsc_csi_dev failing while searching for child device
> intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da).

This sounds like you may not have the actual MEI driver enabled or
that it is not binding.

Do you have both CONFIG_INTEL_MEI_VSC_HW and CONFIG_INTEL_MEI_VSC enabled?

And do you get a driver symlink under /sys/devices/platform/intel_vsc
indicating that a driver has bound to it ?

If not any related messages in dmesg ?

If yes what is the output of:

ls /sys/bus/mei/devices

and of:

ls -l /sys/bus/mei/devices/*/driver

?

Regards,

Hans