Re: [PATCH] spi: Fix acpi deferred irq probe

[Alexis Lothoré <alexis.lothore@xxxxxxxxxxx>]

Hello,

owning a Dell XPS 9320 and struggling to make the freshly merged IPU6
support to work on it, I was about to send a call for help on the media ML,
when I eventually spotted your observations on Redhat's bugzilla ([0]), and
this corresponding patch.

On Fri Nov 22, 2024 at 10:42 AM CET, Stanislaw Gruszka wrote:
> When probing spi device take care of deferred probe of ACPI irq gpio
> similar like for OF/DT case.
>
> From practical standpoint this fixes issue with vsc-tp driver on
> Dell XP 9340 laptop, which try to request interrupt with spi->irq
> equal to -EPROBE_DEFER and fail to probe with the following error:
>
> vsc-tp spi-INTC10D0:00: probe with driver vsc-tp failed with error -22
>
> Suggested-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> Fixes: 33ada67da352 ("ACPI / spi: attach GPIO IRQ from ACPI description to SPI device")
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>

[...]

I systematically observe this issue (probe failure with -22) on each boot,
and reached the same intermediate conclusion (IRQ failing to register, and
spi->irq value being -EPROBE_DEFER).
I can confirm that this patch makes the vsc-tp -22 error disappear on my
machine, and that I have now /sys/devices/platform/intel_vsc.

Unfortunately, I now encounter a new issue preventing the camera to work
(ipu6 still fails with -EPROBE_DEFER, I now have
ipu_bridge_get_ivsc_csi_dev failing while searching for child device
intel_vsc-92335fcf-3203-4472-af93-7b4453ac29da). I am not familiar enough
neither with ACPI nor the exact pipeline involved to explain this yet, but
if you can affirm that is is unrelated to your change, feel free to take
my:

Tested-by: Alexis Lothoré <alexis.lothore@xxxxxxxxxxx> # Dell XPS9320, ov01a10

Thanks,

[0] https://bugzilla.redhat.com/show_bug.cgi?id=2324683#c11

-- 
Alexis Lothoré, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com