Re: [PATCH v1 1/1] mfd: rk8xx: Fix shutdown handler

[Dmitry Osipenko <dmitry.osipenko@xxxxxxxxxxxxx>]

On 7/30/24 21:05, Sebastian Reichel wrote:
> +	/*
> +	 * Currently the Rockchip SPI driver always sleeps when doing SPI
> +	 * transfers. This is not allowed in the SYS_OFF_MODE_POWER_OFF
> +	 * handler, so we are using the prepare handler as a workaround.
> +	 * This should be removed once the Rockchip SPI driver has been
> +	 * adapted.
> +	 */
> +	if (is_spi)
> +		pwr_off_mode = SYS_OFF_MODE_POWER_OFF_PREPARE;

This prevents the syscore_shutdown() step from execution. Is it better
than not powering off?

I'd rather skip registration of the power-off handlers in a case of SPI :)

-- 
Best regards,
Dmitry