Re: [PATCH v6 2/7] spi: bitbang: Implement support for MOSI idle state configuration

[Jonathan Cameron <jic23@xxxxxxxxxx>]

On Sat, 29 Jun 2024 16:05:05 -0300
Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx> wrote:

> Some SPI peripherals may require strict MOSI line state when the controller
> is not clocking out data.
> Implement support for MOSI idle state configuration (low or high) by
> setting the data output line level on controller setup and after transfers.
> Bitbang operations now call controller specific set_mosi_idle() call back
> to set MOSI to its idle state.
> The MOSI line is kept at its idle state if no tx buffer is provided.

Slightly odd wrapping - this doesn't warrant 3 paragraphs, so I'd just
reflow it into one. 

I'm not a fan of counting F's, so would have gone with GENMASK for those
but it's not the local style, so fair enough to hard code them.
FWIW given it's been a long time since I messed around in SPI controller
drivers...

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>


> 
> Acked-by: Nuno Sa <nuno.sa@xxxxxxxxxx>
> Reviewed-by: David Lechner <dlechner@xxxxxxxxxxxx>
> Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>