On 11.06.24 16:21, Colin Foster wrote: > On Fri, Jun 07, 2024 at 04:45:43PM +0100, Mark Brown wrote: >> On Thu, Jun 06, 2024 at 10:14:27PM -0500, Colin Foster wrote: >> >>> So I think the question I have is: >> >>> Should the CS line be de-asserted at the end of "spi_write"? >> >> Absent bodging with cs_change after any spi message the chip select >> should be left deasserted. > > Do you have hardware to reproduce my results of two spi messages no > longer toggling the CS line and leaving the line at GND through the > transactions? Hmmm, I might have missed something, but it looks like nothing happened since that exchange. Did this regression fall through the cracks or can I consider the issue resolved for some reason? Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page. #regzbot poke