RE: [PATCH v3 1/3] spi: fsl-dspi: use common proptery 'spi-cs-setup(hold)-delay-ns'

[Peng Fan <peng.fan@xxxxxxx>]

> Subject: [PATCH v3 1/3] spi: fsl-dspi: use common proptery 'spi-cs-
> setup(hold)-delay-ns'
> 
> Use SPI common DT binding properties 'spi-cs-setup-delay-ns' and 'spi-
> cs-hold-delay-ns'. If these properties do not exist, fall back to legacy
> 'fsl,spi-cs-sck-delay' and 'fsl,spi-sck-cs-delay'.
> 
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
>  drivers/spi/spi-fsl-dspi.c | 14 +++++++++-----
>  1 file changed, 9 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/spi/spi-fsl-dspi.c b/drivers/spi/spi-fsl-dspi.c index
> 0a2730cd07c6a..7c1f8af9d215e 100644
> --- a/drivers/spi/spi-fsl-dspi.c
> +++ b/drivers/spi/spi-fsl-dspi.c
> @@ -1018,11 +1018,15 @@ static int dspi_setup(struct spi_device
> *spi)
>  	pdata = dev_get_platdata(&dspi->pdev->dev);
> 
>  	if (!pdata) {
> -		of_property_read_u32(spi->dev.of_node, "fsl,spi-cs-
> sck-delay",
> -				     &cs_sck_delay);
> -
> -		of_property_read_u32(spi->dev.of_node, "fsl,spi-sck-
> cs-delay",
> -				     &sck_cs_delay);
> +		cs_sck_delay = spi_delay_to_ns(&spi->cs_setup, NULL);
> +		if (!cs_sck_delay)

`if (cs_sck_delay <= 0)` ?

> +			of_property_read_u32(spi->dev.of_node,
> "fsl,spi-cs-sck-delay",
> +					     &cs_sck_delay);
> +
> +		sck_cs_delay = spi_delay_to_ns(&spi->cs_hold, NULL);
> +		if (!sck_cs_delay)

` if (sck_cs_delay <= 0)`?

Regards,
Peng.

> +			of_property_read_u32(spi->dev.of_node,
> "fsl,spi-sck-cs-delay",
> +					     &sck_cs_delay);
>  	} else {
>  		cs_sck_delay = pdata->cs_sck_delay;
>  		sck_cs_delay = pdata->sck_cs_delay;
> 
> --
> 2.34.1
>