Re: [PATCH v2] spi: mux: Fix master controller settings after mux select

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Wed, Apr 24, 2024 at 2:18 PM Heikki Keranen
<heikki.keranen@xxxxxxxxxxx> wrote:
>
> In some cases SPI child devices behind spi-mux require different
> settings like: max_speed_hz, mode and bits_per_word.
>
> Typically the slave device driver puts the settings in place and calls
> spi_setup() once during probe and assumes they stay in place for all
> following spi transfers.
>
> However spi-mux forwarded spi_setup() -call to SPI master driver only
> when slave driver calls spi_setup(). If second slave device was
> accessed meanwhile and that driver called spi_setup(), the
> settings did not change back to the first spi device.
> In case of wrong max_speed_hz this caused spi trasfers to fail.

SPI transfers

> This commit adds spi_setup() call after mux is changed. This way
> the right device specific parameters are set to the master driver.
>
> The fix has been tested by using custom hardware and debugging
> spi master driver speed settings.

...

> ---
> Changes in v2:
> - fixed Co-authored-by -> Co-developed-by
> - added Signed-off-by for co-developer
>   both suggested by Andy Shevchenko, thanks!

As I said this was already applied and AFAIK Mark won't rebase, that's
why I gave you advice for the future contributions.

But thanks for following!

-- 
With Best Regards,
Andy Shevchenko