Re: [PATCH] spi: mux: Fix master controller settings after mux select

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Mon, Apr 22, 2024 at 02:41:50PM +0300, Heikki Keranen kirjoitti:
> In some cases SPI child devices behind spi-mux require different
> settings like: max_speed_hz, mode and bits_per_word.
> 
> Typically the slave device driver puts the settings in place and calls
> spi_setup() once during probe and assumes they stay in place for all
> following spi transfers.
> 
> However spi-mux forwarded spi_setup() -call to SPI master driver only
> when slave driver calls spi_setup(). If second slave device was
> accessed meanwhile and that driver called spi_setup(), the
> settings did not change back to the first spi device.
> In case of wrong max_speed_hz this caused spi trasfers to fail.
> 
> This commit adds spi_setup() call after mux is changed. This way
> the right device specific parameters are set to the master driver.
> 
> The fix has been tested by using custom hardware and debugging
> spi master driver speed settings.

> Co-authored-by: Petri Tauriainen <petri.tauriainen@xxxxxxxxxxx>

Since it's already applied for the future please note, the correct tag is
Co-developed-by and in accordance with Submitting Patches it must followed by
the respective Signed-off-by. In this case it had to be

Co-developed-by: Petri Tauriainen <petri.tauriainen@xxxxxxxxxxx>
Signed-off-by: Petri Tauriainen <petri.tauriainen@xxxxxxxxxxx>


-- 
With Best Regards,
Andy Shevchenko






[Index of Archives]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux