On Tue, Mar 26, 2024 at 08:44:11PM +0200, Andy Shevchenko wrote: > On Tue, Mar 26, 2024 at 06:25:16PM +0000, Mark Brown wrote: > > On Tue, Mar 26, 2024 at 08:22:59PM +0200, Andy Shevchenko wrote: > > > On Tue, Mar 26, 2024 at 06:16:28PM +0000, Mark Brown wrote: > > > > I think the ACPI dependency there is as much about hiding the device on > > > > irrelevant platforms as anything else, might be better replaced with an > > > > x86 dependency though. ... > > That's nice but I'm not sure what that has to do with the dependency on > > ACPI? > ACPI_PTR() makes ID no-op only if ACPI is defined. That also satisfies > the ugly ifdeffery that is removed by this patch as well. If there is > no dependency we will have compiler warning for defined but not used > variable. Again I don't think that's the main purpose of the dependency here.
Attachment:
signature.asc
Description: PGP signature