RE: [PATCH 2/5] spi: spi-nxp-fspi: change the default lut index

[Bough Chen <haibo.chen@xxxxxxx>]

> -----Original Message-----
> From: Michael Walle <mwalle@xxxxxxxxxx>
> Sent: 2023年12月14日 0:25
> To: Bough Chen <haibo.chen@xxxxxxx>
> Cc: broonie@xxxxxxxxxx; Han Xu <han.xu@xxxxxxx>; dl-linux-imx
> <linux-imx@xxxxxxx>; linux-spi@xxxxxxxxxxxxxxx; yogeshgaur.83@xxxxxxxxx;
> Michael Walle <mwalle@xxxxxxxxxx>
> Subject: Re: [PATCH 2/5] spi: spi-nxp-fspi: change the default lut index
> 
> > The fspi dynamic lut use the last lut for all IPS operations, the
> > imx8ulp only supports 15 luts, so change the last lut index from
> 
> It's 16 LUTs, no? There's also index 0.

Yes, should be 16 LUTs.

> 
> > 31 to 15.
> >
> > Signed-off-by: Han Xu <han.xu@xxxxxxx>
> > Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
> > ---
> >  drivers/spi/spi-nxp-fspi.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/spi/spi-nxp-fspi.c b/drivers/spi/spi-nxp-fspi.c
> > index 0feecf5ba010..9d6b4d22263c 100644
> > --- a/drivers/spi/spi-nxp-fspi.c
> > +++ b/drivers/spi/spi-nxp-fspi.c
> > @@ -64,9 +64,9 @@
> >  /*
> >   * The driver only uses one single LUT entry, that is updated on
> >   * each call of exec_op(). Index 0 is preset at boot with a basic
> > - * read operation, so let's use the last entry (31).
> > + * read operation, so let's use the last entry (15).
> 
> Please add the information about the imx8mulp to the comment.
> Otherwise, the comment will be confusing for SoCs where there are 32 LUTs.

Yes, will add.

Best Regards
Haibo Chen
> 
> -michael
> 
> >   */
> > -#define	SEQID_LUT			31
> > +#define	SEQID_LUT			15
> >
> >  /* Registers used by the driver */
> >  #define FSPI_MCR0			0x00
> > --
> 2.34.1
>