On Wed, Nov 29, 2023 at 02:55:18PM +0100, Linus Walleij wrote: > On Wed, Nov 29, 2023 at 2:32 PM Nam Cao <namcao@xxxxxxxxxxxxx> wrote: > > #define SPI_TRANS_FAIL_NO_START BIT(0) > > +#define SPI_TRANS_FAIL_IO BIT(1) > > Is it obvious from context when these flags get set? > from transfer_one() and in which flag field? > > Otherwise maybe we should add a comment. Agree that the purpose of this flag is not clear. I will add some description in v2. Best regards, Nam
Re: [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting
- From: Nam Cao <namcao@xxxxxxxxxxxxx>
- Date: Wed, 29 Nov 2023 15:15:09 +0100
- Cc: broonie@xxxxxxxxxx, linux-arm-kernel@xxxxxxxxxxxxxxxxxxx, linux-spi@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
- In-reply-to: <CACRpkdZYZUP9rnXbqO1BaHe_e5R8m30sYuPmfhj=VcDS-drZjg@mail.gmail.com>
- References: <cover.1701264413.git.namcao@linutronix.de> <361901574eec1271c0969edba6492d3f2132fade.1701264413.git.namcao@linutronix.de> <CACRpkdZYZUP9rnXbqO1BaHe_e5R8m30sYuPmfhj=VcDS-drZjg@mail.gmail.com>
- References:
- [PATCH 0/2] spi: spl022: fix sleeping in interrupt context
- From: Nam Cao
- [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting
- From: Nam Cao
- Re: [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting
- From: Linus Walleij
- [PATCH 0/2] spi: spl022: fix sleeping in interrupt context
- Prev by Date: Re: [PATCH 2/2] spi: spl022: switch to use default spi_transfer_one_message()
- Next by Date: [PATCH v2 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting
- Previous by thread: Re: [PATCH 1/2] spi: introduce SPI_TRANS_FAIL_IO for error reporting
- Next by thread: [PATCH 2/2] spi: spl022: switch to use default spi_transfer_one_message()
- Index(es):
 |