Re: [PATCH -next 17/24] spi: s3c64xx: switch to use modern name

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 16/08/2023 12:27, Geert Uytterhoeven wrote:
> Hi Yang,
> 
> CC Andi, Krzysztof, Alim
> 
> On Wed, Aug 16, 2023 at 11:43 AM Yang Yingliang
> <yangyingliang@xxxxxxxxxx> wrote:
>> Change legacy name master/slave to modern name host/target or controller.
>>
>> No functional changed.
>>
>> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>
> 
> Thanks for your patch!
> 
>> --- a/drivers/spi/spi-s3c64xx.c
>> +++ b/drivers/spi/spi-s3c64xx.c
>> @@ -38,7 +38,7 @@
>>
>>  #define S3C64XX_SPI_CH_HS_EN           (1<<6)  /* High Speed Enable */
>>  #define S3C64XX_SPI_CH_SW_RST          (1<<5)
>> -#define S3C64XX_SPI_CH_SLAVE           (1<<4)
>> +#define S3C64XX_SPI_CH_TARGET          (1<<4)
> 
> I assume the register bit name comes straight from the hardware
> documentation, so you cannot just change it without making future
> maintenance harder.

Yep. SLAVE is term from datasheet. Code is easier to read/maintain with
old name.

Best regards,
Krzysztof