Re: [PATCH -next 17/24] spi: s3c64xx: switch to use modern name

[Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>]

Hi Yang,

CC Andi, Krzysztof, Alim

On Wed, Aug 16, 2023 at 11:43 AM Yang Yingliang
<yangyingliang@xxxxxxxxxx> wrote:
> Change legacy name master/slave to modern name host/target or controller.
>
> No functional changed.
>
> Signed-off-by: Yang Yingliang <yangyingliang@xxxxxxxxxx>

Thanks for your patch!

> --- a/drivers/spi/spi-s3c64xx.c
> +++ b/drivers/spi/spi-s3c64xx.c
> @@ -38,7 +38,7 @@
>
>  #define S3C64XX_SPI_CH_HS_EN           (1<<6)  /* High Speed Enable */
>  #define S3C64XX_SPI_CH_SW_RST          (1<<5)
> -#define S3C64XX_SPI_CH_SLAVE           (1<<4)
> +#define S3C64XX_SPI_CH_TARGET          (1<<4)

I assume the register bit name comes straight from the hardware
documentation, so you cannot just change it without making future
maintenance harder.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds